tests: Fix import error for c23 module#64
Open
MrKevinWeiss wants to merge 1 commit intoiot-lab:masterfrom
Open
tests: Fix import error for c23 module#64MrKevinWeiss wants to merge 1 commit intoiot-lab:masterfrom
MrKevinWeiss wants to merge 1 commit intoiot-lab:masterfrom
Conversation
For some strange reason, it seems like using from module_a import module_b from module_b import module_c will not work... I guess any from imports must be an existing module and cannot be something brought in. Note the in this example module_b is usable just not importable. We have had some failing tests which I was able to reproduce locally. In this case it is regarding the mock -> python2 and unittest.mock -> python3 abstraction. One can use or print the imported mock, but cannot from x import y it. The solution is to just import all the from x import y within the version abstraction branch. It has been locally tested allowing mock to still be used.
Author
|
I found some more info on it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some strange reason, it seems like using
will not work... I guess any from imports must be an existing module and cannot be something brought in.
Note in this example
module_bis usable just not "from" importable.We have had some failing tests which I was able to reproduce locally.
In this case it is regarding the mock -> python2 and unittest.mock -> python3 abstraction.
One can use or print the imported mock, but cannot
from x import yit.The solution is to just import all the
from x import ywithin the version abstraction branch.It has been locally tested allowing mock to still be used.
The failure was discovered during RIOT release tests